dotty.tools.scripting.BashScriptsTests are not running properly, but tests are succeeding

[magnolia-k]

[info] Test run started
[info] Test dotty.tools.scripting.BashScriptsTests.verifyScalaArgs started
osname[linux]
bashExe: [/bin/bash]

/bin/bash: /home/vagrant/dotty/compiler/target/scala-3.0.0/test-classes/scripting/showArgs.sc: Permission denied
[info] Test dotty.tools.scripting.BashScriptsTests.verifyScalacArgs started
osname[linux]
bashExe: [/bin/bash]

/bin/bash: -script: command not found
[info] Test run finished: 0 failed, 0 ignored, 2 total, 0.061s

BashScriptsTests uses the which function provided by ClasspathTests to get the path of scala and scalac commands, but this function depends on the environment variable PATH, so it cannot get the path of the built binary.

As a result, the which function returns an empty string, and BashScriptsTests interprets the following first argument as a command and tries to execute it.

39   val scalacPath = which("scalac")
40   val scalaPath = which("scala")

[dwijnand]

This is in CI (as opposed to just when tests are run locally), so I think it merits a priority bump.

[dwijnand]

@philwalk do you think this is an easy fix?

[philwalk]

I'll look at today, it sounds like an easy fix.

[magnolia-k]

@philwalk @dwijnand

Looking at the results of the CI run, the path seems to be incorrect

osname[linux]
bashExe: [/usr/bin/bash]
[info] Test run started
[info] Test dotty.tools.scripting.BashScriptsTests.verifyScalaArgs started

/usr/bin/bash: dist/target/pack/bin/scala: No such file or directory
scalacPath[dist/target/pack/bin/scalac]
[info] Test dotty.tools.scripting.BashScriptsTests.verifyScalacArgs started
osname[linux]
bashExe: [/usr/bin/bash]

/usr/bin/bash: dist/target/pack/bin/scalac: No such file or directory
[info] Test run finished: 0 failed, 0 ignored, 2 total, 0.029s

[philwalk]

I'm not yet familiar with the CI run, is scala already installed somewhere that we can look for at test time? I will look into it when I get a chance. If you can you point me to the section in the logs where the error message occurs, that would help.

The directory dist/target/pack/bin only exists after sbt dist/pack, can that be added in the CI environment?
Otherwise, the fix might be to disable the test if dist/target/pack/bin/scalac is not found.

[magnolia-k]

It will not be generated unless dist/pack is executed between compilation(compile) and testing(test).

.github/workflows/ci.yaml

https://github.com/lampepfl/dotty/blob/504b1c2f596a6e3ed21fc6d841322e027b97c1f2/.github/workflows/ci.yaml#L67-L70

[philwalk]

So should .github/workflows/ci.yaml be modified?
Or should the test be conditional on finding bin/scalac?