Add implementation of distinctBy #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
It is not clear to me why the binary compatibility tests are failing. It seems the value of |
Closed
SethTisue
force-pushed
the
alexklibisz-543
branch
2 times, most recently
from
d1859d8 to
3234b3c
Compare
|
the MiMa thing went away on rebase (thanks to #595 I guess?) I also did |
SethTisue
force-pushed
the
alexklibisz-543
branch
from
3234b3c to
cdeb60d
Compare
SethTisue
approved these changes
Jun 14, 2023
|
thank you @alexklibisz ! I'll roll a release before too much longer (ticket on that is #603) |
mergify bot
referenced
this pull request
in slick/slick
Jun 16, 2023
…2.11.0 (#2749) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [org.scala-lang.modules:scala-collection-compat](http://www.scala-lang.org/) ([source](https://github.com/scala/scala-collection-compat)) | minor | `2.10.0` -> `2.11.0` | --- ### Release Notes <details> <summary>scala/scala-collection-compat</summary> ### [`v2.11.0`](https://github.com/scala/scala-collection-compat/releases/tag/v2.11.0): 2.11.0 [Compare Source](https://github.com/scala/scala-collection-compat/compare/v2.10.0...v2.11.0) #### What's Changed - Add `RegexOps` by [@​jozic](https://github.com/jozic) in [https://github.com/scala/scala-collection-compat/pull/595](https://github.com/scala/scala-collection-compat/pull/595) - Add implementation of distinctBy by [@​alexklibisz](https://github.com/alexklibisz) in [https://github.com/scala/scala-collection-compat/pull/602](https://github.com/scala/scala-collection-compat/pull/602) #### New Contributors - [@​jozic](https://github.com/jozic) made their first contribution in [https://github.com/scala/scala-collection-compat/pull/595](https://github.com/scala/scala-collection-compat/pull/595) - [@​alexklibisz](https://github.com/alexklibisz) made their first contribution in [https://github.com/scala/scala-collection-compat/pull/602](https://github.com/scala/scala-collection-compat/pull/602) **Full Changelog**: scala/scala-collection-compat@v2.10.0...v2.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/slick/slick). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTcuMyIsInVwZGF0ZWRJblZlciI6IjM1LjExNy4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #543
Shamelessly lifted @xuwei-k 's recommended implementation and added a few unit tests. Happy to expand as necessary.