Skip to content

Conversation

@julienrf
Copy link
Contributor

See scala/scala-library-next#93 (comment)

However, I have a few issues:

  • there are no tests
  • I’m not sure about the fact that these settings are assigned to the root project only

@julienrf julienrf requested a review from SethTisue July 28, 2021 09:38
@julienrf julienrf force-pushed the add-sbt-version-policy branch from 9ba5c62 to efe29a8 Compare July 28, 2021 10:43
@SethTisue
Copy link
Member

This looks plausible to me. We can always revise after we have some experience with it in the actual module repos.

@julienrf julienrf self-assigned this Aug 2, 2021
@julienrf
Copy link
Contributor Author

julienrf commented Aug 2, 2021

Let me try it locally on a few modules before we merge it.

@julienrf
Copy link
Contributor Author

julienrf commented Aug 3, 2021

OK, this looks good to me. We have to take care of the correct scoping of the settings, but it works. Could you please release 2.4.0 after it is merged?

@SethTisue SethTisue merged commit ad0daf3 into 2.x Aug 3, 2021
@SethTisue SethTisue deleted the add-sbt-version-policy branch August 3, 2021 16:33
@SethTisue
Copy link
Member

should be on its way to Maven Central

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants