This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Fix soundness issues #519
Closed
Fix soundness issues #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specializations were all unsound since they typically returned WithFilter of
a collection {Iterable/Map/Set} where a mutable or immutable collection was required.
We need to either drop them or come up with a sound design.
There were three methods specialized in ArrayDeque to return some structure of ArrayDeques instead of the underlying collection type. These were inherited without overridng by Queue and Stack. This means the contract is broken: The type says that e.g. sliding returns an Iterator[Queue] but in reality it returns an Iterator[ArrayDeque].
Contributor
Author
|
The dotty branch that compiles this has been merged into master (PR #4162). @allanrenucci can you add a commit or do a separate PR to use the right dotty version for the build? |
Closed
Contributor
|
Superseded by #521 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes or silences the soundness issues discovered by the recent tightening of checks in Dotty. The main changes were
This was pretty hard going, in particular figuring out the problems in the WithFilter swamp. Please, let's merge this quickly and let's not fail dotty compilation again. It would be great if this was the last time I had to rescue the dotty build.