This repository was archived by the owner on Dec 22, 2021. It is now read-only.
Make MapWrapper.Entry's hashCode conform to the contract in java.util.Map.Entry's documentation #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Map.Entry's documentation
julienrf
approved these changes
Feb 27, 2018
Contributor
Author
|
Thanks for the fast review @julienrf ! Anything left to do before merging? |
Contributor
Author
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of scala/scala#6233 , which fixes scala/bug#10663
In the above PR, I also deleted a test (test/files/run/t5880.scala) that was testing for good spread in the (better but incorrect) hashcode implementation. I don't see that same test anywhere in this repo however.