Skip to content

Allow MediaSource to be passed in to URL.createObjectURL #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2023
Merged

Allow MediaSource to be passed in to URL.createObjectURL #794

merged 4 commits into from
Jul 20, 2023

Conversation

yilinwei
Copy link
Contributor

See here.

armanbilge
armanbilge reviewed Jul 17, 2023
View reviewed changes
armanbilge
armanbilge reviewed Jul 17, 2023
View reviewed changes
armanbilge
armanbilge approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@armanbilge armanbilge changed the title Allow File and MediaSource to be passed in to URL.createObjectURL Allow MediaSource to be passed in to URL.createObjectURL Jul 17, 2023
@armanbilge armanbilge merged commit ed4b27c into scala-js:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yilinwei @armanbilge