Fix Scala 2.10 IDE validation failures #70
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbinary's master specifies sbt version explicitly which fixes dbuild failure. As a bonus, it also supports building with sbt 0.13.x. The 0.4.2 tag supports sbt 0.12.x only. Building with sbt 0.13.x should make everything a bit more smooth.
When building zinc, dbuild seems to be not picking up property passed to it when doing repository configuration resolution. Dbuild is invoked this way: bin/dbuild -DprRepoUrl=http://private-repo.typesafe.com/typesafe/scala-pr-validation-snapshots/ sbt-on-2.10.x The relevant line in `zinc/bin/dbuild.properties` looks like that: pr-scala: ${prRepoUrl-https://oss.sonatype.org/content/repositories/snapshots} This means, it should use the `prRepoUrl` property if defined. For reason that I didn't figure out it doesn't pick up that property. My work-around is to replace the default value with the one that should be picked up from the property. The previous default value didn't make much sense anyway.
|
Can one of the admins verify this patch? |
|
Per @dragos, Scala IDE for 2.10 is not maintaned because IDE has cross-version support for Scala now. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check individual commits for details.