Skip to content

Conversation

@nnsW3
Copy link
Contributor

@nnsW3 nnsW3 commented Aug 28, 2024

Hello
I found and fixed several minor spelling issues.
Br, elias.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (adaeb54) to head (601989e).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files          19       19           
  Lines        1069     1069           
=======================================
  Hits         1033     1033           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Everything LGTM apart from comment about the api.md doc change...

@nnsW3
Copy link
Contributor Author

nnsW3 commented Aug 28, 2024

done

Copy link
Member

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you. 💯

@cgewecke cgewecke merged commit fcf858f into sc-forks:master Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants