Skip to content

Conversation

@cgewecke
Copy link
Member

@cgewecke cgewecke commented Nov 23, 2019

Make it possible to distribute the hit map generated during instrumentation to multiple api.ganache invocations, as necessary.

Make the folder name istanbul writes coverage reports configurable so multiple runs can be combined.

  • Refactor api.ganache and test providing client from solcoverjs
  • Add api level setters/getters for instrumentationData
  • Add istanbulFolder option for custom istanbul destinations
  • Add json to the list of default reporters

@codecov-io
Copy link

codecov-io commented Nov 23, 2019

Codecov Report

Merging #436 into buidler-plugin will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           buidler-plugin     #436      +/-   ##
==================================================
+ Coverage           99.21%   99.21%   +<.01%     
==================================================
  Files                  18       18              
  Lines                 760      763       +3     
==================================================
+ Hits                  754      757       +3     
  Misses                  6        6
Impacted Files Coverage Δ
dist/plugin-assets/plugin.utils.js 97.26% <ø> (ø) ⬆️
lib/ui.js 100% <ø> (ø) ⬆️
dist/plugin-assets/buidler.ui.js 100% <ø> (ø) ⬆️
dist/plugin-assets/buidler.utils.js 100% <ø> (ø) ⬆️
lib/api.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2e6c3...af4f90f. Read the comment docs.

@cgewecke cgewecke changed the title API Refinements Prepare API for parallelization Nov 23, 2019
@cgewecke cgewecke merged commit 367ef81 into buidler-plugin Nov 23, 2019
@cgewecke cgewecke deleted the decouple-ganache branch November 23, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants