Skip to content

Conversation

@frangio
Copy link
Contributor

@frangio frangio commented Oct 7, 2019

We've migrated to Codecov. (It's very good!)

@frangio frangio changed the title change openzeppelin coverage report link Change OpenZeppelin coverage report link Oct 7, 2019
@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           6        6           
  Lines         372      372           
  Branches       79       79           
=======================================
  Hits          341      341           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66eb47...8d9a09a. Read the comment docs.

@cgewecke
Copy link
Member

cgewecke commented Oct 7, 2019

@frangio Thanks so much :)

I keep forgetting to mention this but there is one weird thing about codecov X solidity, namely: branch coverage seems to be missing.

I think it's because they use their own JS parsing of target files and it doesn't work for TypeScript, CoffeeScript (or Solidity).

Very hard to tell how meaningful a difference this is at Zeppelin since your coverage is basically perfect....You can always get this info from the locally produced html coverage report in any case.

@cgewecke cgewecke merged commit 50a8cb3 into sc-forks:master Oct 7, 2019
@frangio frangio deleted the patch-1 branch October 7, 2019 22:27
@frangio
Copy link
Contributor Author

frangio commented Oct 7, 2019

Oh that's interesting... Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants