Skip to content

Conversation

@yxliang01
Copy link
Contributor

@yxliang01 yxliang01 commented Sep 20, 2019

We should use https :) As per discussion in #405

P.S. My first PR here :D

@codecov-io
Copy link

codecov-io commented Sep 20, 2019

Codecov Report

Merging #410 into truffle-plugin will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           truffle-plugin     #410   +/-   ##
===============================================
  Coverage           99.05%   99.05%           
===============================================
  Files                  14       14           
  Lines                 636      636           
===============================================
  Hits                  630      630           
  Misses                  6        6
Impacted Files Coverage Δ
lib/ui.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bcca9...0bc805c. Read the comment docs.

@cgewecke cgewecke self-requested a review September 20, 2019 18:46
Copy link
Member

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @yxliang01!

@cgewecke cgewecke merged commit bdd6be5 into sc-forks:truffle-plugin Sep 20, 2019
@yxliang01 yxliang01 deleted the patch-1 branch September 20, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants