Improve coverage #409
Merged
Improve coverage #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## truffle-plugin #409 +/- ##
==================================================
+ Coverage 96.78% 99.05% +2.26%
==================================================
Files 14 14
Lines 654 636 -18
==================================================
- Hits 633 630 -3
+ Misses 21 6 -15
Continue to review full report at Codecov.
|
53 tasks
cgewecke
added a commit
that referenced
this pull request
Sep 25, 2019
+ Remove unused code from `lib/parse.js` + Add invalid reporter test + Remove un-hittable try/catch around backup client load in API.ganache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes on the changes in
lib/parse.jsbased on changes btw solidity-parser & parser-antlrContractDefinition(grammar ref)VariableDeclarationStatement(grammar ref)MemberAccess(and suspended pending AST analysis) (ast ref)UnaryOperation(and suspended pending AST analysis) (ast ref)(These are mostly relevant to statement coverage - most people are probably just looking at line.)
Also:
Raises coverage to 99%