Let preprocessor manage nested conditionals #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=========================================
+ Coverage 92.07% 92.2% +0.12%
=========================================
Files 6 6
Lines 366 372 +6
Branches 79 79
=========================================
+ Hits 337 343 +6
Misses 29 29
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to the (much much) faster algo from #318 for introducing brackets. It was running into trouble with oraclize.
[Edit - just looking over this and I realize there's still a couple weird nested else-if constructions in oraclize that I commented out and don't compile correctly. Have to revisit at some point...]