Skip to content

Conversation

@vibern0
Copy link

@vibern0 vibern0 commented Jan 4, 2019

Hi,

this is an important update for me and I believe is important for the community too.
The changes are very simple, in the first commit I just updated dependencies, since there was a lot of vulnerabilities, according to npm audit. In the second commit, I fixed the errors in order to make the coverage work again. Those changes are mostly related to web3.js package.

PS. Do not merge just yet, I still need to fix the tests.

@hiddentao
Copy link
Contributor

What's the status of this?

@ukstv
Copy link
Contributor

ukstv commented Feb 28, 2019

Just in case, LeapDAO maintains a fork that supports solidity 0.5.x and truffle v5: https://github.com/leapdao/solidity-coverage#master

@area area mentioned this pull request Feb 28, 2019
@area
Copy link
Contributor

area commented Feb 28, 2019

I can confirm that the leapdao fork works. I've actually been working today on updating the tests over here based on the leapdao fork. #318 is the result, and there is a beta published with solidity 0.5.x support - please give it a go and let me know how it goes!

Closing in favour of #318, but I have taken some improvements here and incorporated them too, so thanks for the PR!

@area area closed this Feb 28, 2019
@vibern0
Copy link
Author

vibern0 commented Feb 28, 2019

Hi @area
sure, will be a pleasure. Actually, I've been using my fork in a project for a while. I wanted to update the tests as well but didn't have time. I'm very happy to help with this.
Thank you so much. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants