Skip to content

Conversation

@maxsam4
Copy link
Contributor

@maxsam4 maxsam4 commented Sep 8, 2018

Fixes #289

Added node in-front of the command being executed by childprocess.exec(). This will make sure that windows will execute the js file rather than opening it in a text editor.

Added node in-front of the command to being executed by childprocess.exec(). This will make sure that windows will execute the js file rather than opening it in a text editor.
@codecov-io
Copy link

Codecov Report

Merging #290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files           6        6           
  Lines         368      368           
  Branches       84       84           
=======================================
  Hits          351      351           
  Misses         17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a57b2f9...f0f7dac. Read the comment docs.

@cgewecke
Copy link
Member

@maxsam4 Thanks so much. This might fix #240 too.

@cgewecke cgewecke merged commit 62ab3e5 into sc-forks:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants