Skip to content

[Snyk] Fix for 2 vulnerabilities #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"axios": "^0.17.0",
"axios": "^1.12.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The upgrade of axios from ^0.17.0 to ^1.12.0 is a major version jump from a pre-1.0 release. This may introduce breaking changes, particularly in error handling. The structure of the error object in .catch() blocks might have changed. Please review the axios changelog and test API calls that handle errors, such as the one in app/src/helpers/upload.js.

"classnames": "^2.2.5",
"lodash": "^4.17.4",
"prop-types": "^15.6.0",
"react": "^16.0.0",
"react-dom": "^16.0.0",
"react-router": "^4.2.0",
"react-router-dom": "^4.2.2",
"react-scripts": "1.0.14"
"react-scripts": "5.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading react-scripts from 1.0.14 to 5.0.0 is a massive jump across 4 major versions and will almost certainly introduce breaking changes that break your application. You should expect to perform a significant migration effort. Key considerations include:

  • Node.js Version: react-scripts@5 requires Node.js 14+.
  • React Version: It is designed for React 17/18. Your project's [email protected] is likely incompatible and will need to be upgraded.
  • Toolchain Updates: This brings in major updates like Webpack 5 and Babel 7, which may have their own breaking changes affecting your project if you have any custom configurations.

Before merging, it is essential to test the build, start, and all application functionality thoroughly on a separate branch and address any resulting issues.

},
"scripts": {
"start": "react-scripts start",
Expand Down