This repository was archived by the owner on Oct 24, 2025. It is now read-only.
Make Sass_Values const in API function calls #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
changed the title
|
Hmm, I'm still getting |
|
As I said, you need to make a copy via |
This should help to avoid issues like sass#689 Compiler should emit a warning in that case
mgreter
force-pushed
the
fix/const_sass_values
branch
from
dfb717b to
6274460
Compare
|
If no one has any more objections I'm going to merge this soon! |
mgreter
added a commit
that referenced
this pull request
Dec 16, 2014
Make Sass_Values const in API function calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #689
I'm not 100% sure if this really is the right way to "solve" this issue, but it should at least improve the situation slightly. Compiler will now issue a warning if someone tries to return the same value in custom functions ... if warnings are enabled. Any opinions on this? I'm just not sure what the best way is to tell implementors where a copy is needed and where it is not!?