Regression with custom precision

[mgreter]

Regression introduced in e231c6c
Breaks feature introduced in 07e9ead

Best regards!

[akhleung]

Interesting ... I suppose I could try storing only the precision in the To_String visitor instead of the entire Context object....

[HamptonMakes]

What's the status here...? I'm confused.

[mgreter]

Just tested with perl bindings and it seems that custom precision is stil broken (nsams@e231c6c).

[mgreter]

Reversed the logic @akhleung proposed and added a status bool to context, to flag this situation. Feels hackish, but IMO still better than breaking custom precision. Hope it works as intended.

[HamptonMakes]

Remember though, we are targeting 3.4 which I believe doesn't actually allow this. :/

On Mon, Oct 27, 2014 at 5:17 PM, Marcel Greter notifications@github.com
wrote:

Reversed the logic @akhleung proposed and simply added a status bool to context, to flag this situation. Feels hackish, but IMO still better than breaking custom precision. Hope it works as intended.

Reply to this email directly or view it on GitHub:
#364 (comment)

[mgreter]

Sorry, I dont really understand what you mean? Is custom precision not a feature of sass 3.4?

[xzyfer]

According to the changelog the --precision flag was introduces in 3.1.8 and defaulted to 3. In 3.2.0 it was defaulted to 5. Custom precisions via the --precision flag is still in a thing in ruby sass master.

[HamptonMakes]

I swear I was reading a thread on sass that discussed that... let me look around. Ignore me until I find it as, it could have been a threaded fever dream.

On Mon, Oct 27, 2014 at 7:48 PM, Michael Mifsud notifications@github.com
wrote:

According to the changelog the --precision flag was introduces in 3.1.8 and defaulted to 3. In 3.2.0 it was defaulted to 5. Custom precisions via the --precision flag is still in a thing in ruby sass master.

Reply to this email directly or view it on GitHub:
#364 (comment)

[mgreter]

Closing this issue as it is fixed in 12dbd03