Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@zxv
Copy link
Contributor

@zxv zxv commented May 13, 2015

This pull request addresses Issue #67. HTTP status 200 is returned instead of 500.

In addition, some additional styles are provided to properly add whitespace to the provided SASS errors.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 76.37% when pulling e89d082 on zxv:fix-error-display into 4cc584d on dahlia:python.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 76.37% when pulling e89d082 on zxv:fix-error-display into 4cc584d on dahlia:python.

@dahlia
Copy link
Member

dahlia commented May 14, 2015

Could you rebase it on 0.8-maintananece, and then retarget it to 0.8-maintenance branch instead of master?

@dahlia
Copy link
Member

dahlia commented May 14, 2015

Also, removing existing parameter makes breaking API change. IMHO it would better if it only changes the default value of the parameter.

@zxv
Copy link
Contributor Author

zxv commented May 14, 2015

Will do. I'll open a new pull request with those changes.

@zxv zxv closed this May 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants