This repository was archived by the owner on Oct 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Add more cli opts and source map config args #279
Merged
asottile
merged 1 commit into
sass:master
from
theatlantic:add-source-map-args-cli-opts
Dec 17, 2018
Merged
Add more cli opts and source map config args #279
asottile
merged 1 commit into
sass:master
from
theatlantic:add-source-map-args-cli-opts
Dec 17, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec00f07 to
560ebbb
Compare
|
whoa this is great, there's a lot for me to read through so it might take me a bit to get to it all but this is incredible! |
asottile
reviewed
Dec 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few little things! overall looks good
560ebbb to
734d4ab
Compare
|
I've incorporated the feedback in the latest commit. Let me know if I missed something. |
asottile
approved these changes
Dec 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
thanks for this awesome change! I'll try it out and then hopefully get a release soon |
|
so sorry, I totally forgot about this -- looking at getting #280 in and making a release |
|
this has been released in 0.17.0 🎉 -- thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

I had the need to be able to emit source maps using libsass-python that contain
sourcesContent. When I set out to make a PR to add this functionality I realized that there are quite a few libsass options not exposed through the API, and also that the cli script does not allow setting all of the options that are already exposed. With these PR, the library and cli script are brought into feature parity with other libsass bindings, such as node-sass.Newly added kwargs include:
source_map_contents: EmitssourcesContentproperty in source map (fixes Support embedding sources' contents #268)source_map_embed: Embeds sourcemap as a data uri insourceMappingURLcommentomit_source_map_url: Omits the source map comment from the css output filesource_map_root: Sets thesourceRootproperty in a source mapAll of these are exposed via the cli using the existing naming conventions, i.e.
source_map_contentscan be enabled with--sourcemap-contents.Newly added cli flags that map onto already exposed libsass options:
-i/--indented-syntax: enables sass (not scss) parsing--sourcemap-file: Allows overriding ofsource_map_filenamevia the cli