Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Conversation

@bmwiedemann
Copy link
Contributor

when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.

when building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would usually differ.

See https://reproducible-builds.org/ for why this matters.
@asottile
Copy link
Member

This might need more sort unless walk is deterministic, but otherwise 👍

@asottile
Copy link
Member

Yeah I think you'll need to sort sources (via sources.sort()) after the loop

@bmwiedemann
Copy link
Contributor Author

It helped for me. I can propose a change with sources.sort() if you prefer that.

@bmwiedemann bmwiedemann mentioned this pull request Jul 21, 2017
@asottile
Copy link
Member

superseded by #212

@asottile asottile closed this Jul 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants