-
Notifications
You must be signed in to change notification settings - Fork 57
Add a script to build manylinux wheels #151
Conversation
|
Looks good to me in principal. Perhaps push to testpypi so we can test in action? |
build_manylinux_wheels.py
Outdated
|
|
||
|
|
||
| @contextlib.contextmanager | ||
| def tempdir(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're running on Python 3; there's already a TemporaryDirectory context manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh hey, that's great!
|
They're on testpypi: https://testpypi.python.org/pypi/libsass/0.11.1 Try these with: |
|
Looks fine to me. Could we build manylinux wheels on Travis CI in the future? |
|
Works great for me on Debian jessie and Debian stretch (coincidentally, I was about to open an issue to ask about manylinux1 support!). Thanks! |
|
@dahlia I thought about travis-ci, however it doens't really benefit us to build them there. They need to build in this special docker container and can't take advantage of the software travis-ci has installed (due to being a too-new distribution (said nobody every about precise!)). I think it probably makes sense to just run this one-off during release. |
|
I've gone ahead and uploaded manylinux wheels for 0.11.1, 0.11.0 and 0.10.1 releases. If anyone wants others, let me know and I'll upload those too |
|
Great, thank you very much. Note for anyone else having problems with the non |
Resolves #75
Resolves #150
CC @samuelcolvin
For more on the "manylinux" spec, see the pep: https://www.python.org/dev/peps/pep-0513/
(Personal notes):
.sofiles into the wheel (which has security implications) -- but in our case it doesn't actually bundle any of the shared objects as these are the only things linked (yay?):