Skip to content

Escape unprintable 0x7F (delete control character) #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Escape unprintable 0x7F (delete control character) #2144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e54341
Escape unprintable 0x7F (delete control character)
ntkme Dec 6, 2023
97d7944
Merge branch 'main' of github.com:sass/dart-sass into escape-del
nex3 Dec 8, 2023
5ac3b8c
Add a CHANGELOG entry
nex3 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* Produce better output for numbers with complex units in `meta.inspect()` and
debugging messages.

* Escape U+007F DELETE when serializing strings.

* When generating CSS error messages to display in-browser, escape all code
points that aren't in the US-ASCII region. Previously only code points U+0100
LATIN CAPITAL LETTER A WITH MACRON were escaped.
Expand Down
3 changes: 2 additions & 1 deletion lib/src/visitor/serialize.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,8 @@ final class _SerializeVisitor
$fs ||
$gs ||
$rs ||
$us:
$us ||
$del:
_writeEscape(buffer, char, string, i);

case $backslash:
Expand Down