Skip to content

findDOMNode is deprecated; need to use a ref #166

@joefiorini

Description

@joefiorini

Going to try to open a PR for this, but wanted to bring it up in an issue first. findDOMNode is deprecated in favor of refs. I think the safest way to fix this would be to create a single ref that is used in one of two ways:

  1. When using a render prop, pass the ref into the render prop function and require the developer to pass it down to their input (I believe there is precedence for this in other libraries, but need to verify that...)
  2. When not using a render prop, pass the ref straight to the default input that is controlled directly by the input mask component.

I'm going to try this and see what it does to the tests. If it works out, I'll open a PR for it, unless I hear objections here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions