-
Notifications
You must be signed in to change notification settings - Fork 37
Move post history on sidebar #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We've agreed that we should make a template tag that fetches the post history data from the database and includes our template file to render it. |
|
Turned this into a pull request. |
|
The second sentence of this paragraph should be changed or removed: @paulcollinsiii Sorry, I probably did not attach this comment to the right spot. This comment applies to a section of tutorial#1 that has not been changed since the first workshop. Because of the additional instructions about installing django 1.6 before creating a requirement.txt file, the link and suggestion to follow the Django installation instructions seem no longer needed. |
|
@alaindomissy does that comment apply to something in my PR? I'm not seeing that text but it's entirely possible I'm blind. |
Because who doesn't like "the solution for which is left as an exercise for the reader"
tutorials/07-templatetags.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be "Template tags" or maybe "Custom template tags"
tutorials/07-templatetags.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh... a link reference that doesn't go anywhere.
|
I've made a lot of changes to this documentation. I would like some feedback/help on what we have so far. A rendered version can be found here: http://test-driven-django-development.readthedocs.org/en/issue-10/07-templatetags.html |
tutorials/07-templatetags.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add this between the two sentences in this paragraph...
DRY or "Don't Repeat Yourself" is a rule of thumb for good programming practice. http://programmer.97things.oreilly.com/wiki/index.php/Don%27t_Repeat_Yourself
tutorials/07-templatetags.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace "means that" with "enables"
Convert that to a templatetag so we can just toss it in base.html and deal with settings from there.
Put num_display in settings? Make it part of the template tag? Even use a template tag?
@treyhunner and I talked about using a context middleware, but I'm kind of leery of middleware in general.