-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
Stage: Next ReleaseMerged into the `next` branch for the next major release.Merged into the `next` branch for the next major release.Type: RefactorRefactoring existing code to improve long-term sustainability.Refactoring existing code to improve long-term sustainability.
Description
Mypy doesn't like that the retry argument attributes are defined dynamically when a class is instantiated, so it'll complain that they don't exist when a subclass developer is trying to modify them when overriding/extending the parser. If instead of having separate attributes per registered stage, we just had a dict
where the keys are the stage names, mypy would be happy.
Note: This will be a breaking change.
Metadata
Metadata
Assignees
Labels
Stage: Next ReleaseMerged into the `next` branch for the next major release.Merged into the `next` branch for the next major release.Type: RefactorRefactoring existing code to improve long-term sustainability.Refactoring existing code to improve long-term sustainability.