Datetime using the Real Time Clock #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdedman
reviewed
May 25, 2025
user/datetime.c
Outdated
Comment on lines
16
to
18
| // Number of seconds in a year: 31556926 | ||
| // Number of seconds in a month: 2629743 | ||
| // Number of seconds in a day: 86400 |
Member
There was a problem hiding this comment.
To make this a little more explicit, it would be better to define them as constants rather than magic numbers. I will be updating that for you :)
chrisdedman
approved these changes
May 25, 2025
| } | ||
|
|
||
| // Function to getline from user input | ||
| void getlines(char *restrict buffer, size_t length) |
Member
There was a problem hiding this comment.
I feel like this getlines function could be simplified by adding modularity. This would help with improving readability. This is okay for now, but I will probably refactor it in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
dandtoptions for testingMisc Changes
Format_Statestruct definition toinclude/printf.h