Skip to content

Set license field in package.json to BSD-3-Clause #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nbryant
Copy link

@nbryant nbryant commented Apr 19, 2022

Please refer to our Commit Guidelines for documenting changes.

Changes proposed in this pull request:

Acceptance Criteria

General

  • Tested on desktop (see supported browsers)
  • Tested on mobile (for responsive or mobile-specific features)
  • Confirm Accessibility
  • Confirm RTL

Feature

  • Reference User Story work item number in description
  • Add usage examples
  • Add documentation for new usage guidelines
  • Add tests to test new components and implementation usage
  • Add component specific Release notes mentioning the changes
  • If feature requires the implementor to move to a new version, please provide a migration description in the component specific Release notes

Fix

  • Reference Bug work item number in description
  • Add tests to ensure bug does not happen again
  • Add component specific Release notes mentioning the changes

Design Changes

  • Add component specific Release notes mentioning the changes
  • If change requires the implementor to move to a new version, please provide a migration description in the component specific Release notes

Deprecated

  • If css selector is being deprecated, apply the @deprecate annotation to selector comment block

     /**
      * @selector .slds-bar
      * @deprecated
      */
     .slds-bar { ... }
  • If css selector is being deprecated, move deprecated code to _deprecate.scss file and wrap in deprecate mixin.

  • Provide deprecate mixin with version code will become deprecated and a brief description for what the code is being deprecated for.

     @include deprecate('4.0.0', 'Please use slds-foo instead of slds-bar') {
        .slds-bar { ... }
     }

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Nathan Bryant <n***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

@Dottenpixel
Copy link
Contributor

Hi @nbryant, I got SLDS 2.18.0 up here earlier today with the fix to the license value in 73c43b3. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants