Sfos4 fix

[CODeRUS]

No description provided.

[benaryorg]

I haven't gotten an answer in the Jolla Forum thread in three weeks so I'll comment here directly; the build artifacts did expire last month, and in lieu of other packaging (i.e. OpenRepos) the current way of using Patchmanager on 4.0 is compiling the code oneself, pulling sources directly out of the branch used for the PR no less. It would be greatly appreciated if mainline packaging had compatible versions, especially considering the patches are applied in a volatile nature with a way to circumvent the entire process effectively making the update non-lethal so to say.

[CODeRUS]

uploaded here: https://github.com/sailfishos-patches/patchmanager/releases/tag/3.0.1

[Phoenix616]

Patchmanager 3.0.1 itself seems to work fine for me on 4.1.0.24, finding patches that are updated/still work with that version however is a different issue...

[Olf0]

@CODeRUS, while discussing Pull Request #49, you asked why I believe that this Pull Request here breaks compatibility to older SailfishOS releases.
Sorry that it took so much time to answer, but I had looked over this PR #48 only briefly, was sure that there is at least one incompatible change, but wanted to check thoroughly that my assessment is exhaustive (i.e., that there are no incompatible changes I had not detected).

Now I am pretty sure that the only incompatible change is per commit 8d974de in line 57 of patchmanager-daemon.pro (see diff to previous commit here): Changing systemd.path from /lib/systemd/system/ to /usr/lib/systemd/system/.
But I am stating the obvious. Plus, because SailfishOS does not provide a compatibility mechanism for this and a "pro" file it is not a place where one could easily detect and depend on the installed SailfishOS release (in contrast to, e.g., RPM spec files), I see no easy way to avoid this incompatibility, except by maintaining two different Patchmanager branches for SailfishOS releases before (< v3.4.0) and after (≥ v3.4.0) this filesystem layout change.

TL;DR: This is fine for SailfishOS releases ≥ 3.4.0

---

P.S. / edit / addendum

And maybe I was "jumping to conclusions" again, and all my statements above are purely academic:

• The path /usr/lib/systemd/system/ does exist on SailfishOS < 3.4.0
• Although on SailfishOS < 3.4.0 the intended path for system-wide unit-files is /lib/systemd/system/, things will work fine when /usr/lib/systemd/system/ is used and the unit-files are explicitly called there.
• The path /lib/systemd/system/ does not exist on SailfishOS ≥ 3.4.0 (checked on SFOS 4.0.1: /lib/systemd/ does not exist, only /lib/ still does).
  Edit 2: I looked up the original source, the SFOS 3.4.0 release notes, section "Technical changes" (second bullet point there).
• But %{_unitdir}, which is now used (per this PR) in rpm/patchmanager.spec, resolves to /lib/systemd/system/ on SailfishOS < 3.4.0, which mismatches the altered (per this PR), hardcoded path in the "pro" file /usr/lib/systemd/system/ (see src/bin/patchmanager-daemon/patchmanager-daemon.pro).

TL;DR No. 2: This change may be backward compatible (i.e., with SailfishOS releases < 3.4.0), but is necessary for SailfishOS releases ≥ 3.4.0