-
Notifications
You must be signed in to change notification settings - Fork 23
[SFOS 4.6] Support new theme icon location #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the fixup. I really start to hate them for doing such breaking changes as altering arbitrary names regularly. I will try to take a look at it and comprehend what you researched and implemented (I may need this for other projects, too) next weekend. |
|
Thanks for the quick fix! |
Yes, but only those ones which actually use the
In case you need it, these are the steps:
|
Olf0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This took me way longer to figure out than should be necessary.
Background: Sailfish OS 4.6 changes the default path for "theme" icons, such as
the ones used for Settings plugins (which we are).
Additionally, the layout of the source dir for svgs to convert has changed or
the sailfish-svg2png tool.
This drops amost all of src/icons/icons.pro, as that was a verbatim copy of the
upstream sailfish-svg2png .prf file, and just uses that prf file as intended.
I haven't checked, but this may mean we lose some of the icon scales for older
packages, but it should't realy make a noteworthy difference.