Skip to content

Conversation

@nephros
Copy link
Contributor

@nephros nephros commented Nov 4, 2021

... which just adds Capitalization

As we don't have a dedicated -en translation file any more because of
PR #108 , and we can't change the strings directly in the source, as

  • that would likely make the web catalog not work any more
  • would require changing of the .json specification
  • ^^^ would require patch authors to change all .json files
  • would require changing of the web catalog web backend

... this adds translations for strings used in the cpp source

... which just adds Capitalization

As we don't have a dedicated -en translation file any more because of
PR sailfishos-patches#108, and we can't change the strings directly in the source, as

 - that would likely make the web catalog not work any more
 - would require changing of the .json specification
 - ^^^ would require patch authors to change all .json files
 - would require changing of the web catalog web backend

... this adds translations for strings used in the cpp source
@nephros nephros force-pushed the pr/translate-categories-en branch from 835967e to 004e228 Compare November 4, 2021 13:06
@nephros nephros added the debt fallout and other issues originating from the past label Nov 4, 2021
Copy link
Contributor

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O.K.

@nephros nephros merged commit ae138f0 into sailfishos-patches:master Nov 4, 2021
@nephros nephros deleted the pr/translate-categories-en branch November 4, 2021 16:50
@nephros nephros restored the pr/translate-categories-en branch November 5, 2021 12:37
@nephros nephros deleted the pr/translate-categories-en branch February 20, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt fallout and other issues originating from the past

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants