Fix printing of Tate series #41194
Open
Fix printing of Tate series #41194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good to me, and CI failures are unrelated to this fix. |
r-mb
approved these changes
Nov 18, 2025
Contributor
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 19, 2025
The bigoh of a Tate series with a nonzero log-radius is currently incorrectly printed. ``` sage: S.<x> = TateAlgebra(Qp(5), log_radii=[-1]) sage: S(x, 10) (1 + O(5^9))*x + O(5^10 * <5*x>) ``` This should be `O(5^10 * <x/5>)`. This PR fixes this. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#41194 Reported by: Xavier Caruso Reviewer(s): Rubén Muñoz--Bertrand
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 20, 2025
sagemathgh-41194: Fix printing of Tate series The bigoh of a Tate series with a nonzero log-radius is currently incorrectly printed. ``` sage: S.<x> = TateAlgebra(Qp(5), log_radii=[-1]) sage: S(x, 10) (1 + O(5^9))*x + O(5^10 * <5*x>) ``` This should be `O(5^10 * <x/5>)`. This PR fixes this. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#41194 Reported by: Xavier Caruso Reviewer(s): Rubén Muñoz--Bertrand
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 21, 2025
sagemathgh-41194: Fix printing of Tate series The bigoh of a Tate series with a nonzero log-radius is currently incorrectly printed. ``` sage: S.<x> = TateAlgebra(Qp(5), log_radii=[-1]) sage: S(x, 10) (1 + O(5^9))*x + O(5^10 * <5*x>) ``` This should be `O(5^10 * <x/5>)`. This PR fixes this. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#41194 Reported by: Xavier Caruso Reviewer(s): Rubén Muñoz--Bertrand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bigoh of a Tate series with a nonzero log-radius is currently incorrectly printed.
This should be
O(5^10 * <x/5>). This PR fixes this.📝 Checklist