add some typing in modular,modules,plot,schemes,symbolic,topology #41145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 246e679; changes) is ready! 🎉 |
fchapoton
force-pushed
the
typing_contains_2
branch
from
ef30112 to
246e679
Compare
cxzhong
approved these changes
Nov 11, 2025
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 16, 2025
sagemathgh-41145: add some typing in modular,modules,plot,schemes,symbolic,topology mostly about declaring that `__contains__` returns `bool` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41145 Reported by: Frédéric Chapoton Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 16, 2025
sagemathgh-41175: typing "__contains__" in categories,geometry,groups,monoids similar to sagemath#41145 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41175 Reported by: Frédéric Chapoton Reviewer(s): Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 17, 2025
sagemathgh-41145: add some typing in modular,modules,plot,schemes,symbolic,topology mostly about declaring that `__contains__` returns `bool` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41145 Reported by: Frédéric Chapoton Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 17, 2025
sagemathgh-41175: typing "__contains__" in categories,geometry,groups,monoids similar to sagemath#41145 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41175 Reported by: Frédéric Chapoton Reviewer(s): Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 19, 2025
sagemathgh-41145: add some typing in modular,modules,plot,schemes,symbolic,topology mostly about declaring that `__contains__` returns `bool` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41145 Reported by: Frédéric Chapoton Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 19, 2025
sagemathgh-41175: typing "__contains__" in categories,geometry,groups,monoids similar to sagemath#41145 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41175 Reported by: Frédéric Chapoton Reviewer(s): Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 20, 2025
sagemathgh-41145: add some typing in modular,modules,plot,schemes,symbolic,topology mostly about declaring that `__contains__` returns `bool` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41145 Reported by: Frédéric Chapoton Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 20, 2025
sagemathgh-41175: typing "__contains__" in categories,geometry,groups,monoids similar to sagemath#41145 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41175 Reported by: Frédéric Chapoton Reviewer(s): Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 21, 2025
sagemathgh-41145: add some typing in modular,modules,plot,schemes,symbolic,topology mostly about declaring that `__contains__` returns `bool` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41145 Reported by: Frédéric Chapoton Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 21, 2025
sagemathgh-41175: typing "__contains__" in categories,geometry,groups,monoids similar to sagemath#41145 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41175 Reported by: Frédéric Chapoton Reviewer(s): Vincent Macri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly about declaring that
__contains__returnsbool📝 Checklist