require 6 to be a unit in elliptic-curve point addition over non-fields #41055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JohnCremona
approved these changes
Oct 17, 2025
cxzhong
approved these changes
Oct 17, 2025
|
Thanks! |
|
Documentation preview for this PR (built with commit d473ec2; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 18, 2025
sagemathgh-41055: require 6 to be a unit in elliptic-curve point addition over non-fields See sagemath#39191 (comment): The formulas we're using for point addition over non-fields require 6 to be a unit. In this patch we add a `NotImplementedError` when this occurs, and we adjust the random tests to avoid that case. Hopefully fixes sagemath#39191. URL: sagemath#41055 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong, John Cremona
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 19, 2025
sagemathgh-41055: require 6 to be a unit in elliptic-curve point addition over non-fields See sagemath#39191 (comment): The formulas we're using for point addition over non-fields require 6 to be a unit. In this patch we add a `NotImplementedError` when this occurs, and we adjust the random tests to avoid that case. Hopefully fixes sagemath#39191. URL: sagemath#41055 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong, John Cremona
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 20, 2025
sagemathgh-41055: require 6 to be a unit in elliptic-curve point addition over non-fields See sagemath#39191 (comment): The formulas we're using for point addition over non-fields require 6 to be a unit. In this patch we add a `NotImplementedError` when this occurs, and we adjust the random tests to avoid that case. Hopefully fixes sagemath#39191. URL: sagemath#41055 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong, John Cremona
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2025
sagemathgh-41055: require 6 to be a unit in elliptic-curve point addition over non-fields See sagemath#39191 (comment): The formulas we're using for point addition over non-fields require 6 to be a unit. In this patch we add a `NotImplementedError` when this occurs, and we adjust the random tests to avoid that case. Hopefully fixes sagemath#39191. URL: sagemath#41055 Reported by: Lorenz Panny Reviewer(s): Chenxin Zhong, John Cremona
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #39191 (comment): The formulas we're using for point addition over non-fields require 6 to be a unit. In this patch we add a
NotImplementedErrorwhen this occurs, and we adjust the random tests to avoid that case.Hopefully fixes #39191.