Fix libgap(<NumberField>) #40973
Open
Fix libgap(<NumberField>) #40973
+96
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0e7c5bc; changes) is ready! 🎉 |
fchapoton
reviewed
Oct 5, 2025
| a | ||
| Check that libgap global variables does not interfere with this method | ||
| (as it should if the method is correctly implemented and avoid ``libgap.eval``):: |
There was a problem hiding this comment.
does --> do
avoid ---> avoids
| sage: z = QQ['z'].0 | ||
| sage: K.<zeta> = NumberField(z^2 - 2) | ||
| sage: K._gap_init_() # the following variable name $sage1 represents the F.base_ring() in gap and is somehow random | ||
| sage: K._gap_init_() # random (the variable name $sage1 represents F.base_ring() in gap is somehow random) |
There was a problem hiding this comment.
rather write "and is random" so that the sentence is correct
| raise NotImplementedError("Currently, only simple algebraic extensions are implemented in libgap") | ||
|
|
||
| from sage.libs.gap.libgap import libgap | ||
| q = self.polynomial() |
There was a problem hiding this comment.
q is not used ; you could also merge the last 2 lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
libgap(QQ[I])fails. Now it works.also add some minor clean-ups and documentation changes.
The pointed out bug (that is, Sage FiniteField ↔ GAP GF does not keep the
DefiningPolynomial) is to be addressed in a subsequent pull request.context: I was trying to improve the performance of
GF(next_prime(2^128)^4)by using GAP'sStandardFFpackage, see #38376 (comment). but at the moment the conversion between Sage and Gap FiniteField is wrong.📝 Checklist
⌛ Dependencies