Skip to content

PEP8 and typing annotations for function fields #40972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

PEP8 and typing annotations for function fields #40972

wants to merge 16 commits into from

Conversation

vincentmacri
Copy link
Member

@vincentmacri vincentmacri commented Oct 4, 2025 •
edited
Loading

Mostly done with ruff and autotyping, but also some manually for the main function field classes.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@vincentmacri vincentmacri changed the title Code cleanup and typing annotations for function fields PEP8 and typing annotations for function fields Oct 4, 2025
@vincentmacri vincentmacri requested a review from kryzar October 4, 2025 00:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2025

Documentation preview for this PR (built with commit 140807b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

fchapoton
fchapoton approved these changes Oct 4, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but please next time:

  • do no make any change about spaces around arithmetic operators ;
  • rather do only annotations changes, when changing so many files
  • I would also prefer to avoid Literal for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

@kwankyu kwankyu Awaiting requested review from kwankyu

@kryzar kryzar Awaiting requested review from kryzar

Assignees
No one assigned
Labels
s: positive review t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentmacri @fchapoton