Skip to content

Fix an occurrence of lazy_import #40541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2025
Merged

Fix an occurrence of lazy_import #40541

merged 2 commits into from
Aug 16, 2025

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Aug 3, 2025 •
edited
Loading

Previously the following code fails if executed right after Sage starts:

P.<x,y,z> = ProjectiveSpace(QQ, 2)
C = Curve([(x^2 + y^2 - y*z - 2*z^2)*(y*z - x^2 + 2*z^2)*z + y^5], P)
C.ordinary_model()

The error is:

NotImplementedError: object does not support iteration

This pull request fixes it. The reason why it is fixed is explained in the code edit.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025 •
edited
Loading

Documentation preview for this PR (built with commit fc26616; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

JosePisco
JosePisco approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@JosePisco JosePisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended on my end (version 10.7.beta9). Thanks for the fix.

@JosePisco
Copy link
Contributor

I don't have the permission to change labels, someone else will have to do it.

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 10, 2025
a7d331a 
sagemathgh-40541: Fix an occurrence of lazy_import
    
Previously the following code fails if executed right after Sage starts:

```python
P.<x,y,z> = ProjectiveSpace(QQ, 2)
C = Curve([(x^2 + y^2 - y*z - 2*z^2)*(y*z - x^2 + 2*z^2)*z + y^5], P)
C.ordinary_model()
```

The error is:

```python
NotImplementedError: object does not support iteration
```

This pull request fixes it. The reason why it is fixed is explained in
the code edit.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40541
Reported by: user202729
Reviewer(s): grnx
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 12, 2025
710ff3b 
sagemathgh-40541: Fix an occurrence of lazy_import
    
Previously the following code fails if executed right after Sage starts:

```python
P.<x,y,z> = ProjectiveSpace(QQ, 2)
C = Curve([(x^2 + y^2 - y*z - 2*z^2)*(y*z - x^2 + 2*z^2)*z + y^5], P)
C.ordinary_model()
```

The error is:

```python
NotImplementedError: object does not support iteration
```

This pull request fixes it. The reason why it is fixed is explained in
the code edit.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40541
Reported by: user202729
Reviewer(s): grnx
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 13, 2025
0e223d1 
sagemathgh-40541: Fix an occurrence of lazy_import
    
Previously the following code fails if executed right after Sage starts:

```python
P.<x,y,z> = ProjectiveSpace(QQ, 2)
C = Curve([(x^2 + y^2 - y*z - 2*z^2)*(y*z - x^2 + 2*z^2)*z + y^5], P)
C.ordinary_model()
```

The error is:

```python
NotImplementedError: object does not support iteration
```

This pull request fixes it. The reason why it is fixed is explained in
the code edit.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40541
Reported by: user202729
Reviewer(s): grnx
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 14, 2025
615003c 
sagemathgh-40541: Fix an occurrence of lazy_import
    
Previously the following code fails if executed right after Sage starts:

```python
P.<x,y,z> = ProjectiveSpace(QQ, 2)
C = Curve([(x^2 + y^2 - y*z - 2*z^2)*(y*z - x^2 + 2*z^2)*z + y^5], P)
C.ordinary_model()
```

The error is:

```python
NotImplementedError: object does not support iteration
```

This pull request fixes it. The reason why it is fixed is explained in
the code edit.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40541
Reported by: user202729
Reviewer(s): grnx
@vbraun vbraun merged commit bb56716 into sagemath:develop Aug 16, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JosePisco JosePisco JosePisco approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@user202729 @JosePisco @vbraun