Simplify group generic algorithm #40537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 07873ba; changes) is ready! 🎉 |
tscrim
requested changes
Aug 4, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 10, 2025
sagemathgh-40537: Simplify group generic algorithm change a singleton set to a single element. The difference is that in case of singleton set, the element's hash is computed then compared with the pre-stored hash, but then both computing the hash and equality checking is linear time. not sure if it's an improvement. on the other hand the new implementation works even when the type is not hashable. edit: it's likely an improvement, for example with ZZ: ``` a = 3^floor(log(2, 3)*1000) b = 5^floor(log(2, 5)*1000) set_a = {a} %timeit a == b # 32.4 ns %timeit b in set_a # 106 ns ``` `==` can be done in sublinear time too if `==` exits early. The second modification is to call discrete_log_lambda if ord=oo and algorithm parameter is 'lambda' (the documentation says algorithm is only used for prime order group, but discrete_log_lambda works either way). Which makes more sense. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40537 Reported by: user202729 Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 12, 2025
sagemathgh-40537: Simplify group generic algorithm change a singleton set to a single element. The difference is that in case of singleton set, the element's hash is computed then compared with the pre-stored hash, but then both computing the hash and equality checking is linear time. not sure if it's an improvement. on the other hand the new implementation works even when the type is not hashable. edit: it's likely an improvement, for example with ZZ: ``` a = 3^floor(log(2, 3)*1000) b = 5^floor(log(2, 5)*1000) set_a = {a} %timeit a == b # 32.4 ns %timeit b in set_a # 106 ns ``` `==` can be done in sublinear time too if `==` exits early. The second modification is to call discrete_log_lambda if ord=oo and algorithm parameter is 'lambda' (the documentation says algorithm is only used for prime order group, but discrete_log_lambda works either way). Which makes more sense. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40537 Reported by: user202729 Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-40537: Simplify group generic algorithm change a singleton set to a single element. The difference is that in case of singleton set, the element's hash is computed then compared with the pre-stored hash, but then both computing the hash and equality checking is linear time. not sure if it's an improvement. on the other hand the new implementation works even when the type is not hashable. edit: it's likely an improvement, for example with ZZ: ``` a = 3^floor(log(2, 3)*1000) b = 5^floor(log(2, 5)*1000) set_a = {a} %timeit a == b # 32.4 ns %timeit b in set_a # 106 ns ``` `==` can be done in sublinear time too if `==` exits early. The second modification is to call discrete_log_lambda if ord=oo and algorithm parameter is 'lambda' (the documentation says algorithm is only used for prime order group, but discrete_log_lambda works either way). Which makes more sense. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40537 Reported by: user202729 Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 14, 2025
sagemathgh-40537: Simplify group generic algorithm change a singleton set to a single element. The difference is that in case of singleton set, the element's hash is computed then compared with the pre-stored hash, but then both computing the hash and equality checking is linear time. not sure if it's an improvement. on the other hand the new implementation works even when the type is not hashable. edit: it's likely an improvement, for example with ZZ: ``` a = 3^floor(log(2, 3)*1000) b = 5^floor(log(2, 5)*1000) set_a = {a} %timeit a == b # 32.4 ns %timeit b in set_a # 106 ns ``` `==` can be done in sublinear time too if `==` exits early. The second modification is to call discrete_log_lambda if ord=oo and algorithm parameter is 'lambda' (the documentation says algorithm is only used for prime order group, but discrete_log_lambda works either way). Which makes more sense. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40537 Reported by: user202729 Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change a singleton set to a single element. The difference is that in case of singleton set, the element's hash is computed then compared with the pre-stored hash, but then both computing the hash and equality checking is linear time.
not sure if it's an improvement. on the other hand the new implementation works even when the type is not hashable.
edit: it's likely an improvement, for example with ZZ:
==can be done in sublinear time too if==exits early.The second modification is to call discrete_log_lambda if ord=oo and algorithm parameter is 'lambda' (the documentation says algorithm is only used for prime order group, but discrete_log_lambda works either way). Which makes more sense.
📝 Checklist
⌛ Dependencies