- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 684
Show test failures of ci-meson as annotations #39513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Documentation preview for this PR (built with commit 763521d; changes) is ready! 🎉 | 
| Looks good to me. But maybe @tobiasdiez (or somebody else) could sign off on this one? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This has the slight disadvantage that now genuine errors are annotated a few times, but for this the github interface just doesn't give a better solution atm.
| (concerning the two failing tests, can they not be fixed with the alarm-test-helper that you have introduced recently @user202729 ) | 
| The alarm test thing is just a convenient wrapper over  I don't know what's the cause of the test failure, but it says "time out" means even after the "user" press ctrl-C, wait for ≈ 10 minutes, the test still doesn't finish. Of course I've no idea why (last time I check signals cannot be ignored), but that would genuinely be a test failure. I guess we can try to set two alarms somehow (simulate "user press ctrl-C again if it doesn't work the first time"). If tests still fail at least we get a slightly better idea why they do (more likely deadlock, less likely signal ignored/erroneously caught). p/s: actually I did get the (supposedly) lll (low-level lock?) deadlock once locally on my machine, but never got around to debug it. | 
sagemathgh-39513: Show test failures of ci-meson as annotations Follow-up to sagemath#36938 and sagemath#37738 , this PR shows the test failures of ci-meson.yml workflow as GitHub annotations, which has the advantage that you don't need to scroll through the whole log to view the failed tests. (actually I just search for `Failed examples`, but this is not foolproof) Previously only build.yml got this feature. There's a disadvantage, then the file and line numbers are no longer shown in the downloaded log file, instead only `[error]` is shown (but this is trivially fixable by printing the format in both old and new ways when `--format github` is passed). I think if everyone views the annotations instead of reading the raw log anyway, it shouldn't matter too much. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. (no functionality change) - [ ] I have updated the documentation and checked the documentation preview. (no documentation change) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39513 Reported by: user202729 Reviewer(s): Tobias Diez

Follow-up to #36938 and #37738 , this PR shows the test failures of ci-meson.yml workflow as GitHub annotations, which has the advantage that you don't need to scroll through the whole log to view the failed tests.
(actually I just search for
Failed examples, but this is not foolproof)Previously only build.yml got this feature.
There's a disadvantage, then the file and line numbers are no longer shown in the downloaded log file, instead only
[error]is shown (but this is trivially fixable by printing the format in both old and new ways when--format githubis passed). I think if everyone views the annotations instead of reading the raw log anyway, it shouldn't matter too much.📝 Checklist
⌛ Dependencies