Skip to content

sage.coding: Update # needs #38104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 1, 2024
Merged

sage.coding: Update # needs #38104

merged 7 commits into from
Jun 1, 2024

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 28, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 560b929; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kwankyu
kwankyu reviewed May 28, 2024
View reviewed changes
@kwankyu
Copy link
Collaborator

kwankyu commented May 28, 2024

Otherwise lgtm.

dcoudert
dcoudert suggested changes May 28, 2024
View reviewed changes
dcoudert
dcoudert approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I let @kwankyu conclude on the status of this PR.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 29, 2024

Thanks both!

vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
b1d4fa9 
sagemathgh-38104: `sage.coding`: Update `# needs`
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

- Cherry-picked from sagemath#35095.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38104
Reported by: Matthias Köppe
Reviewer(s): David Coudert, Kwankyu Lee, Matthias Köppe
@vbraun vbraun merged commit 2d4f69a into sagemath:develop Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwankyu kwankyu kwankyu left review comments

+1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mkoeppe mkoeppe

Labels

c: coding theory t: refactoring v: large

Projects

None yet

Milestone

sage-10.4

Development

Successfully merging this pull request may close these issues.

4 participants

@mkoeppe @kwankyu @dcoudert @vbraun