Support morphisms in Matroid constructor
#37940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @mkoeppe you may wish to have a look. |
mkoeppe
reviewed
May 6, 2024
mkoeppe
reviewed
May 7, 2024
| elif is_Matrix(data): | ||
| key = 'matrix' | ||
| elif isinstance(data, sage.modules.with_basis.morphism.ModuleMorphism) or ( | ||
| isinstance(data, tuple) and |
There was a problem hiding this comment.
I'm not sure if I find "tuple" input very convincing.
Does it have a clear benefit over just passing the groundset via the groundset parameter?
There was a problem hiding this comment.
The reason I did this is so that the following works:
sage: M = matroids.catalog.Fano()
sage: A = M.representation(order=True, labels=True)
sage: Matroid(A)
...
There was a problem hiding this comment.
I need to do something similar for matrices though.
There was a problem hiding this comment.
I made it so that this also works and retains the groundset labels:
sage: M = matroids.catalog.Fano()
sage: A = M.representation(labels=True)
sage: Matroid(A)
...
mkoeppe
reviewed
May 7, 2024
| key = 'graph' | ||
| elif is_Matrix(data): | ||
| key = 'matrix' | ||
| elif isinstance(data, sage.modules.with_basis.morphism.ModuleMorphism) or ( |
There was a problem hiding this comment.
instead of using isinstance with this class, I think it's better to use isinstance(data, Morphism) and data.category_for().is_subcategory(Modules(data.base_ring()).WithBasis())
There was a problem hiding this comment.
Not sure what's best but the above doesn't seem to work.
Also get groundset labels
|
LGTM, thanks! |
|
Documentation preview for this PR (built with commit 13e499a; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
sagemathgh-37940: Support morphisms in `Matroid` constructor This follows the merging of sagemath#37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the `Matroid` constructor. Example: ``` sage: M = matroids.catalog.Fano() sage: A = M.representation(order=True); A Generic morphism: From: Free module generated by {'a', 'b', 'c', 'd', 'e', 'f', 'g'} over Finite Field of size 2 To: Free module generated by {0, 1, 2} over Finite Field of size 2 sage: Matroid(A) Binary matroid of rank 3 on 7 elements, type (3, 0) ``` URL: sagemath#37940 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
sagemathgh-37940: Support morphisms in `Matroid` constructor This follows the merging of sagemath#37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the `Matroid` constructor. Example: ``` sage: M = matroids.catalog.Fano() sage: A = M.representation(order=True); A Generic morphism: From: Free module generated by {'a', 'b', 'c', 'd', 'e', 'f', 'g'} over Finite Field of size 2 To: Free module generated by {0, 1, 2} over Finite Field of size 2 sage: Matroid(A) Binary matroid of rank 3 on 7 elements, type (3, 0) ``` URL: sagemath#37940 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37940: Support morphisms in `Matroid` constructor This follows the merging of sagemath#37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the `Matroid` constructor. Example: ``` sage: M = matroids.catalog.Fano() sage: A = M.representation(order=True); A Generic morphism: From: Free module generated by {'a', 'b', 'c', 'd', 'e', 'f', 'g'} over Finite Field of size 2 To: Free module generated by {0, 1, 2} over Finite Field of size 2 sage: Matroid(A) Binary matroid of rank 3 on 7 elements, type (3, 0) ``` URL: sagemath#37940 Reported by: gmou3 Reviewer(s): gmou3, Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the merging of #37692 and it enables the (re-)feeding of a linear matroid's morphism representation into the
Matroidconstructor.Example: