- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 684
Fix doctest basenames when Sage library cannot be found with SAGE_LIB #37647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| @tornaria Please take a look if this is solving the problem for you. (I haven't tested very thoroughly yet.) | 
| I will have to look at this carefully. | 
| 
 No, it doesn't. As a matter of fact in my example from #37645  Thus, this PR is not fixing anything broken. | 
| 
 That's rather surprising. If you have a moment, could you share how you tested this? | 
| 
 The link is up there in the description of #37645: #37138 (comment) I did exactly what I describe in that comment (which passes all tests in normal mode) and then repeat the last line but with  | 
| Documentation preview for this PR (built with commit 2f81d78; changes) is ready! 🎉 | 
This lets you specify SAGE_SRC like /path/to/test/dir/../../src/dir, which avoids post-install test failures in sage/doctest/test.py
as it resolves symlinks
…gnize nodoctest marker files
In fact, we remove the use of
SAGE_LIBand replace what depended on this by recognizing certain package data directories of the Sage library.Fixes doctest failures reported in #37645.
Fixes #22445.
📝 Checklist
⌛ Dependencies