Skip to content

Fix a couple of doctests that trigger when building from sdist #37645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix a couple of doctests that trigger when building from sdist #37645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fcb251
doctest: fix missing `tdlib.pyx` when `sagemath-tdlib` not installed
tornaria Mar 21, 2024
1f7f42b
doctest: make sage.doctest.test more robust
tornaria Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 22 additions & 22 deletions src/sage/doctest/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,47 +54,47 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 tolerance.rst
**********************************************************************
File "tolerance.rst", line ..., in sage.doctest.tests.tolerance
File "tolerance.rst", line ..., in ...tolerance
Failed example:
print(":-(") # abs tol 0.1
Expected:
:-)
Got:
:-(
**********************************************************************
File "tolerance.rst", line ..., in sage.doctest.tests.tolerance
File "tolerance.rst", line ..., in ...tolerance
Failed example:
print("1.0 2.0 3.0") # abs tol 0.1
Expected:
4.0 5.0
Got:
1.0 2.0 3.0
**********************************************************************
File "tolerance.rst", line ..., in sage.doctest.tests.tolerance
File "tolerance.rst", line ..., in ...tolerance
Failed example:
print("Hello") # abs tol 0.1
Expected:
1.0
Got:
Hello
**********************************************************************
File "tolerance.rst", line ..., in sage.doctest.tests.tolerance
File "tolerance.rst", line ..., in ...tolerance
Failed example:
print("1.0") # abs tol 0.1
Expected:
Hello
Got:
1.0
**********************************************************************
File "tolerance.rst", line ..., in sage.doctest.tests.tolerance
File "tolerance.rst", line ..., in ...tolerance
Failed example:
print("Hello 1.1") # abs tol 0.1
Expected:
Goodbye 1.0
Got:
Hello 1.1
**********************************************************************
File "tolerance.rst", line ..., in sage.doctest.tests.tolerance
File "tolerance.rst", line ..., in ...tolerance
Failed example:
print("Hello 1.0") # rel tol 1e-6
Expected:
Expand All @@ -104,7 +104,7 @@
Tolerance exceeded:
0.999999 vs 1.0, tolerance 2e-6 > 1e-6
**********************************************************************
File "tolerance.rst", line ..., in sage.doctest.tests.tolerance
File "tolerance.rst", line ..., in ...tolerance
Failed example:
print("Hello 1.0") # rel tol 1e-6
Expected:
Expand All @@ -124,15 +124,15 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 initial.rst
**********************************************************************
File "initial.rst", line 4, in sage.doctest.tests.initial
File "initial.rst", line 4, in ...initial
Failed example:
a = binomiak(10,5) # random to test that we still get the exception
Exception raised:
Traceback (most recent call last):
...
NameError: name 'binomiak' is not defined
**********************************************************************
File "initial.rst", line 14, in sage.doctest.tests.initial
File "initial.rst", line 14, in ...initial
Failed example:
binomial(10,5)
Expected:
Expand All @@ -155,7 +155,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 initial.rst
**********************************************************************
File "initial.rst", line 4, in sage.doctest.tests.initial
File "initial.rst", line 4, in ...initial
Failed example:
a = binomiak(10,5) # random to test that we still get the exception
Exception raised:
Expand Down Expand Up @@ -200,7 +200,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 keyboardinterrupt.rst
**********************************************************************
File "keyboardinterrupt.rst", line 11, in sage.doctest.tests.keyboardinterrupt
File "keyboardinterrupt.rst", line 11, in ...keyboardinterrupt
Failed example:
raise KeyboardInterrupt
Exception raised:
Expand Down Expand Up @@ -302,7 +302,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 fail_and_die.rst
**********************************************************************
File "fail_and_die.rst", line 5, in sage.doctest.tests.fail_and_die
File "fail_and_die.rst", line 5, in ...fail_and_die
Failed example:
this_gives_a_NameError
Exception raised:
Expand All @@ -327,7 +327,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 sig_on.rst
**********************************************************************
File "sig_on.rst", line 6, in sage.doctest.tests.sig_on
File "sig_on.rst", line 6, in ...sig_on
Failed example:
sig_on_count() # check sig_on/off pairings (virtual doctest)
Expected:
Expand All @@ -336,7 +336,7 @@
1
**********************************************************************
1 item had failures:
1 of 5 in sage.doctest.tests.sig_on
1 of 5 in ...sig_on
[3 tests, 1 failure, ...]
----------------------------------------------------------------------
sage -t --warn-long 0.0 --random-seed=0 sig_on.rst # 1 doctest failed
Expand All @@ -356,7 +356,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 simple_failure.rst
**********************************************************************
File "simple_failure.rst", line 7, in sage.doctest.tests.simple_failure
File "simple_failure.rst", line 7, in ...simple_failure
Failed example:
a * b
Expected:
Expand All @@ -365,7 +365,7 @@
15
**********************************************************************
1 item had failures:
1 of 5 in sage.doctest.tests.simple_failure
1 of 5 in ...simple_failure
[4 tests, 1 failure, ...]
----------------------------------------------------------------------
sage -t --warn-long 0.0 --random-seed=0 simple_failure.rst # 1 doctest failed
Expand All @@ -381,7 +381,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 simple_failure.rst
**********************************************************************
File "simple_failure.rst", line 7, in sage.doctest.tests.simple_failure
File "simple_failure.rst", line 7, in ...simple_failure
Failed example:
a * b
Expected:
Expand All @@ -390,7 +390,7 @@
15
**********************************************************************
1 item had failures:
1 of 5 in sage.doctest.tests.simple_failure
1 of 5 in ...simple_failure
[4 tests, 1 failure, ...]
----------------------------------------------------------------------
sage -t --warn-long 0.0 --random-seed=0 simple_failure.rst # 1 doctest failed
Expand All @@ -406,7 +406,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 simple_failure.rst
**********************************************************************
File "simple_failure.rst", line 7, in sage.doctest.tests.simple_failure
File "simple_failure.rst", line 7, in ...simple_failure
Failed example:
a * b
Expected:
Expand All @@ -424,7 +424,7 @@
Returning to doctests...
**********************************************************************
1 item had failures:
1 of 5 in sage.doctest.tests.simple_failure
1 of 5 in ...simple_failure
[4 tests, 1 failure, ...]
----------------------------------------------------------------------
sage -t --warn-long 0.0 --random-seed=0 simple_failure.rst # 1 doctest failed
Expand Down Expand Up @@ -553,7 +553,7 @@
Doctesting 1 file.
sage -t --warn-long 0.0 --random-seed=0 random_seed.rst
**********************************************************************
File "random_seed.rst", line 3, in sage.doctest.tests.random_seed
File "random_seed.rst", line 3, in ...random_seed
Failed example:
randint(5, 10)
Expected:
Expand All @@ -562,7 +562,7 @@
5
**********************************************************************
1 item had failures:
1 of 2 in sage.doctest.tests.random_seed
1 of 2 in ...random_seed
[1 test, 1 failure, ...s]
----------------------------------------------------------------------
sage -t --warn-long 0.0 --random-seed=0 random_seed.rst # 1 doctest failed
Expand Down
2 changes: 1 addition & 1 deletion src/sage/misc/package_dir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def read_distribution(src_file):

sage: from sage.env import SAGE_SRC
sage: from sage.misc.package_dir import read_distribution
sage: read_distribution(os.path.join(SAGE_SRC, 'sage', 'graphs', 'graph_decompositions', 'tdlib.pyx'))
sage: read_distribution(os.path.join(SAGE_SRC, 'sage', 'graphs', 'graph_decompositions', 'tdlib.pyx')) # needs tdlib
'sagemath-tdlib'
sage: read_distribution(os.path.join(SAGE_SRC, 'sage', 'graphs', 'graph_decompositions', 'modular_decomposition.py'))
''
Expand Down