Skip to content

Approve without body #36341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Approve without body #36341

wants to merge 4 commits into from

Conversation

@soehms
Copy link
Member

@soehms soehms commented Sep 26, 2023

This PR implements the changes requested in #36292 (comment)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

soehms and others added 4 commits September 18, 2023 08:06
@soehms
sync_labels_fixes_part2 initial
f507826
@soehms
Fix method on_label_removal (#10)
15f6f2e 
* fix_on_label_removal initial

* fix_on_label_removal state -> status

* fix bug in actor valid

* once again

* rewrite authors in actor_valid

* syntax

* replace warning by hint
@soehms
Merge branch 'sagemath:develop' into sync_labels_fixes_part2
adf4a66
@soehms
approve_without_body initial
3c5a08a
@soehms soehms closed this Sep 26, 2023
@soehms
Copy link
Member Author

soehms commented Sep 26, 2023

This was relative to the wrong repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@soehms