- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 688
 
          sage.rings: Reformat doctests, add # optional annotations
          #35457
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            vbraun
  merged 52 commits into
  sagemath:develop
from
mkoeppe:sage_rings_optional_annotations
  
      
      
   
  May 28, 2023 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            52 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      dae9b08
              
                sage.rings: Add # optional
              
              
                mkoeppe 4d20f8a
              
                sage.rings: Reformat doctests and # optional
              
              
                mkoeppe 2e8a3bb
              
                sage.rings: More # optional
              
              
                mkoeppe 2d4a62b
              
                sage.rings: Reformat doctests and # optional
              
              
                mkoeppe 1c15000
              
                src/sage/misc/cachefunc.pyx: Update doctest output
              
              
                mkoeppe c1721ab
              
                src/sage/rings/multi_power_series_ring_element.py: Fix up
              
              
                mkoeppe a0e7176
              
                sage.rings: Align # optional
              
              
                mkoeppe f00b281
              
                sage.rings: Doctest cosmetics
              
              
                mkoeppe ab389e2
              
                sage.rings: More doctest cosmetics
              
              
                mkoeppe 1a09248
              
                src/sage/rings/integer.pyx: Fix up
              
              
                mkoeppe 64d094c
              
                src/sage/rings/polynomial/multi_polynomial_sequence.py: Doctest cosmeβ¦
              
              
                mkoeppe 0148f5c
              
                src/sage/rings/polynomial/multi_polynomial_sequence.py: Fix up
              
              
                mkoeppe d7b15d2
              
                sage.rings: More doctest cosmetics
              
              
                mkoeppe d8bd93c
              
                src/sage/sets/set_from_iterator.py: Fix up doctest
              
              
                mkoeppe 92f759b
              
                Merge tag '10.0.beta9' into sage_rings_optional_annotations
              
              
                mkoeppe bf431b4
              
                src/sage/rings/factorint.pyx: Revert; this file is handled in #35502
              
              
                mkoeppe 7c692b9
              
                sage.rings: Docstring/doctest cosmetics
              
              
                mkoeppe 7260301
              
                src/sage/misc/sageinspect.py: Update doctest output
              
              
                mkoeppe 9f22bf8
              
                sage.rings.polynomial: Docstring cosmetics
              
              
                mkoeppe 27884d3
              
                sage.rings.polynomial: Fix docstring markup
              
              
                mkoeppe 9f1d9e8
              
                src/sage/rings/polynomial/polynomial_zz_pex.pyx: Fix typo
              
              
                mkoeppe d2546a6
              
                src/doc/en/reference/rings/index.rst: Add sage.rings.abc
              
              
                mkoeppe 9ece1bd
              
                sage.rings: Fix docstring markup, # optional
              
              
                mkoeppe 7e95b66
              
                sage.rings: Fix some # optional
              
              
                mkoeppe f5c7df6
              
                src/sage/rings/polynomial/symmetric_ideal.py: Fix some # optional
              
              
                mkoeppe 1e649be
              
                sage.rings: Fix some # optional
              
              
                mkoeppe 7be1a73
              
                src/sage/rings/laurent_series_ring.py: Add # optional - sage.symbolic
              
              
                mkoeppe bc4abf6
              
                src/sage/rings/polynomial/symmetric_ideal.py: Docstring cosmetics
              
              
                mkoeppe c4eed97
              
                src/sage/rings/integer.pyx: Docstring markup fix
              
              
                mkoeppe 5889ded
              
                git grep -l -E 'Returns? [Tt]rue' src/sage/rings | xargs sed -i.bak -β¦
              
              
                mkoeppe f9c3508
              
                src/sage/rings/fraction_field_FpT.pyx: Docstring cosmetics
              
              
                mkoeppe 50d6426
              
                src/sage/rings/number_field/number_field.py: Docstring cosmetics
              
              
                mkoeppe b0822d3
              
                src/sage/rings/number_field: Docstring cosmetics
              
              
                mkoeppe a13254b
              
                src/sage/rings/number_field/number_field_ideal.py: Docstring cosmetics
              
              
                mkoeppe 1f20e69
              
                src/sage/rings/number_field/number_field[_ideal]_rel.py: Docstring coβ¦
              
              
                mkoeppe 0718614
              
                src/sage/rings/number_field/order.py: Docstring cosmetics
              
              
                mkoeppe 22f7c56
              
                src/sage/rings/padics: Doctest cosmetics
              
              
                mkoeppe 32606c6
              
                src/sage/rings/padics: Fix up markup
              
              
                mkoeppe 0693bd6
              
                src/sage/rings/number_field/number_field.py: Fix markup, doctest
              
              
                mkoeppe ffd8c23
              
                src/sage/rings/padics: Fix up markup
              
              
                mkoeppe bf1b53d
              
                src/sage/rings/number_field: Docstring cosmetics
              
              
                mkoeppe 8b427ec
              
                src/sage/rings/padics: Docstring cosmetics
              
              
                mkoeppe 791a774
              
                sage.rings: Docstring cosmetics, add # optional - sage.symbolic
              
              
                mkoeppe 2b9ffee
              
                sage.rings: Add more # optional - sage.symbolic
              
              
                mkoeppe 8f26789
              
                sage.rings: Add more # optional - sage.symbolic
              
              
                mkoeppe fd1d43b
              
                Merge tag '10.0.rc0' into sage_rings_optional_annotations
              
              
                mkoeppe 8c9808b
              
                src/sage/rings/polynomial/multi_polynomial_sequence.py: Add # optional
              
              
                mkoeppe ed969da
              
                src/sage/misc/latex_macros.py: Add \lcm
              
              
                mkoeppe a4aac37
              
                Merge remote-tracking branch 'upstream/develop' into sage_rings_optioβ¦
              
              
                mkoeppe 96701e5
              
                Merge remote-tracking branch 'upstream/develop' into sage_rings_optioβ¦
              
              
                mkoeppe 507b919
              
                src/sage/rings/padics: Fix doc markup
              
              
                mkoeppe 1fa90d0
              
                src/sage/misc/latex.py: Update doctest output
              
              
                mkoeppe File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -8,6 +8,7 @@ Base Classes for Rings, Algebras and Fields | |
| :maxdepth: 1 | ||
| 
     | 
||
| sage/rings/ring | ||
| sage/rings/abc | ||
| 
     | 
||
| Ideals | ||
| ------ | ||
| 
          
            
          
           | 
    ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| # sage.doctest: optional - sage.rings.finite_rings | ||
| r""" | ||
| Algebraic closures of finite fields | ||
| 
     | 
||
| 
          
            
          
           | 
    ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the warning message. Does it show in the doctesting?