Remove imports from sage.arith.all in the Sage library

[mkoeppe]

sage.arith is a namespace package after #33011, so we remove imports from sage.arith.all throughout the library

https://doc.sagemath.org/html/en/developer/packaging_sage_library.html#module-level-runtime-dependencies

Component: refactoring

Branch/Commit: u/mkoeppe/remove_imports_from_sage_arith_all_in_the_sage_library @ d6ce90c

Issue created by migration from https://trac.sagemath.org/ticket/34197

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1,4 @@
+`sage.arith` is a namespace package after #33011, so we remove imports from `sage.arith.all` throughout the library 
 
+https://doc.sagemath.org/html/en/developer/packaging_sage_library.html#module-level-runtime-dependencies
+

[mkoeppe]

Branch: u/mkoeppe/remove_imports_from_sage_arith_all_in_the_sage_library

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1011578

Remove some imports from sage.arith.all

[sagetrac-git]

Commit: 1011578

[mkoeppe]

Author: Matthias Koeppe, ...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e044d0d	git grep -l 'sage.arith.all import' | xargs sed -E -i.bak 's/sage.arith.all import (lcm|LCM) *$/sage.arith.functions import \1/'
7ab066e	Remove some imports from sage.arith.all

[sagetrac-git]

Changed commit from 1011578 to 7ab066e

[mantepse]

comment:7

The changes in sfa.py and generating_series.py will probably create a (trivial) conflict (which requires manual interaction) with #34470.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2c9bea2	git grep -l 'sage.arith.all import' | xargs sed -E -i.bak 's/sage.arith.all import (lcm|LCM) *$/sage.arith.functions import \1/'
27d0333	Remove some imports from sage.arith.all

[sagetrac-git]

Changed commit from 7ab066e to 27d0333

[mkoeppe]

comment:9

        from . import padics
      File "/__w/sagetrac-mirror/sagetrac-mirror/src/sage/schemes/elliptic_curves/padics.py", line 26, in <module>
        from . import padic_lseries as plseries
      File "/__w/sagetrac-mirror/sagetrac-mirror/src/sage/schemes/elliptic_curves/padic_lseries.py", line 75, in <module>
        from sage.arith.functions import LCM
    ImportError: cannot import name 'LCM' from 'sage.arith.functions' (/__w/sagetrac-mirror/sagetrac-mirror/src/sage/arith/functions.cpython-38-x86_64-linux-gnu.so)

as seen in https://github.com/sagemath/sagetrac-mirror/actions/runs/3440141879/jobs/5738263597

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d6ce90c

src/sage/schemes/elliptic_curves/padic_lseries.py: Fix up import

[sagetrac-git]

Changed commit from 27d0333 to d6ce90c

[mkoeppe]

comment:11

The remaining doctest failure

sage -t --random-seed=29164138248827613754957725053409603108 doc/de/a_tour_of_sage/index.rst  # 1 doctest failed

... is unrelated to the changes here

[mkoeppe]

comment:12

We can close this ticket as a duplicate; the new tool sage -fiximports added in #34945 can make these changes automatically.