GH Actions: Re-add pyright check

[tobiasdiez]

Originally added in #30404, then removed in #32491, now it's back: the pyright check via the github actions.

I've changed the pyright config so that some of the errors are demoted to warnings (all of the demoted errors occurred at least 100 times and thus are not fixable in a single ticket). This made it check now pass on the complete sage source code.

Also fixed a handful of errors that pyright reported:

• Missing closed bracket in smallgraphs by removing leading zeros in the numbers (might actually be a bug in pyright)
• Remove global declaration in latex, where pyright complained about global appearing before import. If I understand it correctly, then global is not needed here (because sage_configurable_latex_macros is not a global variable in the latex module)
• Remove duplicate import in free_module

CC: @mkoeppe @fchapoton

Component: build

Author: Tobias Diez

Branch/Commit: acad07c

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33456

[tobiasdiez]

comment:1

Actually, it is not quite working since pyright complains (at least locally) about missing imports like sage.libs.sirocco, database_knotinfo, gambit, igraph. I think these are all related to optional packages. What's the easiest way to install all optional python packages in the build & test workflow?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1bff99a

Readd pyright and fix small errors

[sagetrac-git]

Commit: 1bff99a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2b17d9c

Demote missing imports to warning for now as well

[sagetrac-git]

Changed commit from 1bff99a to 2b17d9c

[tobiasdiez]

comment:4

Replying to @tobiasdiez:

Actually, it is not quite working since pyright complains (at least locally) about missing imports like sage.libs.sirocco, database_knotinfo, gambit, igraph. I think these are all related to optional packages. What's the easiest way to install all optional python packages in the build & test workflow?

I've demoted the reportMissingImports error to a warning for now.

[sagetrac-git]

Changed commit from 2b17d9c to 4b7b3c8

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4b7b3c8

Merge remote-tracking branch 'origin/develop' into public/build/pyright_github

[sagetrac-git]

Changed commit from 4b7b3c8 to 06b5b98

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7f92032	Readd pyright and fix small errors
06b5b98	Demote missing imports to warning for now as well