Features for latex packages

[mkoeppe]

Add Features LaTeXPackage to detect presence of latex packages.

Depends on #32174

CC: @seblabbe @kwankyu

Component: refactoring

Author: Matthias Koeppe

Branch: e22c173

Reviewer: Kwankyu Lee, Sébastien Labbé

Issue created by migration from https://trac.sagemath.org/ticket/32926

[mkoeppe]

Branch: u/mkoeppe/features_for_latex_packages

[mkoeppe]

Dependencies: #32174

[mkoeppe]

Last 10 new commits:

12f7c98	src/sage/features/polymake.py: Add all_features
c9312db	src/sage/features: Add more all_features functions
230d135	src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Fix doctest markup
7a8f48c	src/sage/features/sagemath.py (sage_features): Unused now, removed
e7f538d	sage.features.bliss: Change name of BlissLibrary feature to libbliss, remove it from all_features
12a2507	src/sage/features/interfaces.py: Fix indentation in docstring
0dd76b6	Merge tag '9.5.beta7' into t/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used
07b2512	src/sage/misc/latex.py: Conditionalize some doctests on latex_package_tkz_graph
2dd9ad3	Merge #32174
42d35b0	src/sage/features/latex.py (TeXFile, LaTeXPackage, 'latex_package_tkz_graph'): New

[mkoeppe]

Commit: 42d35b0

[seblabbe]

comment:4

When testing the feature, I get:

NameError: name 'FeatureNotPresentError' is not defined

an import is missing.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

da1e922

src/sage/features/latex.py: Add missing import

[sagetrac-git]

Changed commit from 42d35b0 to da1e922

[kwankyu]

comment:8

diff --git a/src/sage/features/latex.py b/src/sage/features/latex.py
index 7b95796be4..7bd8d72164 100644
--- a/src/sage/features/latex.py
+++ b/src/sage/features/latex.py
@@ -147,7 +147,7 @@ class TeXFile(StaticFile):
         sage: from sage.features.latex import TeXFile
         sage: TeXFile('x', 'x.tex').is_present()  # optional: pdflatex
         FeatureTestResult('x', True)
-        sage: TeXFile('nonexisting', 'fajfhjdksf-nonexisting-file.tex').is_present()  # optional: pdflatex
+        sage: TeXFile('nonexisting', 'xxxxxx-nonexisting-file.tex').is_present()  # optional - pdflatex
         FeatureTestResult('nonexisting', False)
     """
     def __init__(self, name, filename, **kwds):
@@ -161,7 +161,7 @@ class TeXFile(StaticFile):
 
             sage: from sage.features.latex import TeXFile
             sage: feature = TeXFile('latex_class_article', 'article.cls')
-            sage: feature.absolute_path()  # optional: pdflatex
+            sage: feature.absolute_path()  # optional - pdflatex
             '.../latex/base/article.cls'
         """
         from subprocess import run, CalledProcessError, PIPE
@@ -183,7 +183,7 @@ class LaTeXPackage(TeXFile):
     EXAMPLES::
 
         sage: from sage.features.latex import LaTeXPackage
-        sage: LaTeXPackage('graphics').is_present()  # optional: pdflatex
+        sage: LaTeXPackage('graphics').is_present()  # optional - pdflatex
         FeatureTestResult('latex_package_graphics', True)
     """
     @staticmethod

Otherwise, looks good to me.

[kwankyu]

Reviewer: Kwankyu Lee

[mkoeppe]

comment:10

I agree with these changes, please push them to the ticket

[kwankyu]

Changed branch from u/mkoeppe/features_for_latex_packages to public/32926

[kwankyu]

Changed commit from da1e922 to none

[sagetrac-git]

Commit: ddac7bc