./configure --disable-doc

[mkoeppe]

This switch will disable the docbuild and avoid installing its many dependencies (sphinx...).

In contrast to other packages, pplpy's docbuild is enabled unless explicitly disabled by setting SAGE_SPKG_INSTALL_DOCS=no. We move it to a separate package pplpy_doc and make it a dependency of sagemath_doc_html.

Split out from #31396.

We also add argon2_cffi and nbclient to the packages disabled upon --disable-notebook.

Depends on #29039

CC: @tobiasdiez @dimpase @jhpalmieri @sagetrac-tmonteil

Component: build: configure

Author: Matthias Koeppe, John Palmieri

Branch/Commit: 43221d0

Reviewer: John Palmieri, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32759

[mkoeppe]

Branch: u/mkoeppe/__configure___disable_doc

[sagetrac-git]

Commit: 18b4055

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

97b9fcf	configure.ac (--disable-doc): Disable also 'requests' and its dependencies, and direct sphinx dependencies
18b4055	build/pkgs/pplpy/dependencies: Depend on sphinx only if SAGE_SPKG_INSTALL_DOCS!=no

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,4 +1,7 @@
 This switch will disable the docbuild and installation of its many dependencies (sphinx...)
+
+In contrast to other packages, `ppl`'s docbuild is enabled unless explicitly disabled by setting `SAGE_SPKG_INSTALL_DOCS=no`.
+We conditionalize the dependency of `ppl` on this and also on `sphinx` being in the list of installed packages.
 
 Split out from #31396.
 

[sagetrac-git]

Changed commit from 18b4055 to dfd23fb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

dfd23fb

build/pkgs/pplpy/dependencies: Fix up SAGE_SPKG_INSTALL_DOCS logic

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Changed commit from dfd23fb to 7307c75

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7307c75

configure.ac (--disabled-notebook): Also disable nbclient

[mkoeppe]

Description changed:

--- 
+++ 
@@ -5,3 +5,5 @@
 
 Split out from #31396.
 
+We also add another package to those that are disabled upon `--disable-notebook`.
+

[jhpalmieri]

comment:9

If --disable-doc is given, then should doc be removed from the all-start target, so that make doesn't try to build the docs?

[jhpalmieri]

comment:10

Also, after I used ./configure --disable-doc, packages like alabaster and sphinxcontrib-... were built anyway.

[mkoeppe]

comment:11

Replying to @jhpalmieri:

If --disable-doc is given, then should doc be removed from the all-start target, so that make doesn't try to build the docs?

Yes, that's a good idea.

[jhpalmieri]

comment:12

config.log says (for example)

configure:45112: result: sphinx-4.2.0:                                standard, but disabled using configure option

but maybe the problem is that I ran make instead of make build?

[mkoeppe]

comment:13

Yes, probably the all-start target pulled in the doc dependencies.