sage.structure.element: Add abc Expression; deprecate is_Expression etc.

[mkoeppe]

(part of meta-ticket #32414)

in sage.structure.element, we add a class Expression

• the existing class sage.symbolic.expression.Expression will be its only subclass
• deprecate is_Expression, replace uses by isinstance(x, sage.structure.element.Expression)

Follow-up in #32665: Also deprecate is_SymbolicEquation, is_CallableSymbolicExpression, is_SymbolicVariable; replace uses by isinstance(x, Expression) and a method call (may need a new method is_callable)

Depends on #32599

CC: @DaveWitteMorris @tscrim @mjungmath

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: ee7640c

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32638

[mkoeppe]

Branch: u/mkoeppe/sage_structure_element__add_abc_expression__deprecate_is_expression_etc_

[mkoeppe]

New commits:

37ee682

sage.structure.element.Expression: New abc for sage.symbolic.expression.Expression

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,6 +1,6 @@
 (part of meta-ticket #32414)
 
 in `sage.structure.element`, we add a class `Expression`
-- the existing class `sage.symbolic.expression.Expression` will be renamed to `Expression_pynac` and be its only subclass
+- the existing class `sage.symbolic.expression.Expression` will be its only subclass
 - deprecate `is_Expression`, `is_SymbolicEquation`, `is_CallableSymbolicExpression`, `is_SymbolicVariable`; replace uses by `isinstance(x, Expression)` and a method call (may need a new method `is_callable`)
 

[mkoeppe]

Commit: 37ee682

[sagetrac-git]

Changed commit from 37ee682 to 08bf900

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

56d1c36	git grep -l -E 'is_Expression' | xargs sed -E -i.bak 's/sage[.]symbolic.*import is_Expression *$/sage.structure.element import Expression/;s/is_Expression[(]([^)]*)[)]/isinstance(\1, Expression)/g;'
08bf900	is_Expression: Undo automatic edit of the definition; deprecate

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,5 +2,7 @@
 
 in `sage.structure.element`, we add a class `Expression`
 - the existing class `sage.symbolic.expression.Expression` will be its only subclass
-- deprecate `is_Expression`, `is_SymbolicEquation`, `is_CallableSymbolicExpression`, `is_SymbolicVariable`; replace uses by `isinstance(x, Expression)` and a method call (may need a new method `is_callable`)
+- deprecate `is_Expression`
 
+Follow-up: Also deprecate `is_SymbolicEquation`, `is_CallableSymbolicExpression`, `is_SymbolicVariable`; replace uses by `isinstance(x, Expression)` and a method call (may need a new method `is_callable`)
+

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

comment:4

setting to needs_review so that the patchbot runs

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4e5fe35

src/sage/symbolic/expression.pxd: Undo automatic edit

[sagetrac-git]

Changed commit from 08bf900 to 4e5fe35

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

e14259b

src/sage/ext/fast_callable.pyx: Fix up clash of sage.ext.fast_callable.Expression and sage.structure.element.Expression

[sagetrac-git]

Changed commit from 4e5fe35 to e14259b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

daed11e

src/sage/symbolic/function.pyx: Update imports

[sagetrac-git]

Changed commit from e14259b to daed11e